Merged
Conversation
Member
bluetech
commented
Nov 11, 2025
bluetech
commented
- Convert the configuration file to TOML - everyone likes TOML right? (tox.ini next?)
- Use recent coverage built-in support for subprocess, simplifying tox a bit. Found via https://hynek.me/articles/turbo-charge-tox/#making-coverage-work. Let's see if it works in CI.
bluetech
force-pushed
the
coverage-improvements
branch
from
b2ac1f2 to
79b2104
Compare
bluetech
commented
Nov 11, 2025
| @@ -111,7 +90,6 @@ deps = | |||
| asynctest: asynctest | |||
| xdist: pytest-xdist>=2.1.0 | |||
| xdist: -e . | |||
Member
Author
There was a problem hiding this comment.
(Unrelated) Actually curious why this is done, might check it sometime...
nicoddemus
approved these changes
Nov 12, 2025
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Coverage seems the same, so LGTM!
webknjaz
reviewed
Nov 12, 2025
Member
There was a problem hiding this comment.
Alternatively, coveragepy will soon support a dedicated .coveragerc.toml.
Member
|
To determine this precisely, we'd have to compare individual uploads in the right sidebar @ https://app.codecov.io/gh/pytest-dev/pytest/commit/79b21040bc2f20f70a5015cc07f3964420d55b0e/tree vs. https://app.codecov.io/gh/pytest-dev/pytest/commit/ce8b8a7b4b360ac5f3953b8c3b8b59e6bb420f37/tree. Otherwise, it's easy to miss drops in individual CI jobs when some places are covered by more than one. |
Member
Author
|
Looks the same to me, I think this works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.